[python] Stabilize deferred BLOB limit tests with native plans - #9106
Closed
XiaoHongbo-Hope wants to merge 1 commit into
Closed
[python] Stabilize deferred BLOB limit tests with native plans#9106XiaoHongbo-Hope wants to merge 1 commit into
XiaoHongbo-Hope wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The deferred BLOB reader tests used a limited scan to construct their input splits. Native planning may satisfy the limit with the first split and does not guarantee the same split order as Python planning, so the tests could fail without a reader regression.
Plan the complete split list before applying the reader limit, and make the authorization assertion independent of unordered scan results.
Tests
deferred_blob_resolve_test.py: 15 passed with native planninggit diff --check