[python] Avoid an extra file-size I/O for Blob reads - #9125
Merged
JingsongLi merged 4 commits intoAug 9, 2026
Conversation
XiaoHongbo-Hope
marked this pull request as ready for review
August 9, 2026 03:44
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Avoid the extra file-size lookup performed when
SplitReadcreates aFormatBlobReader.DataFileMetaalready contains the file size, so object-store reads do not need an additional metadata request before reading the Blob footer and index.Changes
file_sizeargument toFormatBlobReader.DataFileMeta.file_sizein both normal and Data Evolution raw Blob read paths.FormatBlobReaderis constructed without a valid file size.Tests
FileIO.get_file_size.SplitReadBlob paths forwardDataFileMeta.file_size.git diff --checkpassed.