[core][spark]: support rewrite_manifest procedure - #9195
Open
zhongyujiang wants to merge 6 commits into
Open
Conversation
zhongyujiang
changed the title
zhongyujiang
marked this pull request as draft
August 12, 2026 12:51
zhongyujiang
changed the title
Add a rewrite_manifest Spark procedure that reads all manifest entries, sorts them globally by partition -> bucket -> level -> fileName (canceling ADD/DELETE pairs of the same file along the way) and writes them back as new manifest files so that ManifestFileMeta statistics become more compact for scan pruning. The sort runs distributed via a Spark sortByKey shuffle. - ManifestEntrySortKey: serializable sort key with byte[] partition for Kryo compatibility and lazy RecordComparator - FileStoreCommit#replaceManifest: optimistic-concurrency commit with conflict detection (containsAll) and concurrent delta preservation - RewriteManifestProcedure: distributed sortByKey + streaming ADD/DELETE cancellation + where clause + auto parallelism - FormatTableCommit: add unsupported replaceManifests - register rewrite_manifest in SparkProcedures - tests: ManifestEntrySortKeyTest (9), FileStoreCommitTest replaceManifest conflict scenarios (3), RewriteManifestProcedureTest (8) Co-Authored-By: Claude <noreply@anthropic.com>
rewritten_manifests_count should be the number of input manifests rewritten (currentManifests), not the output. added_manifests_count should be the number of new manifests produced (newManifests), not the net delta. Also rename the post-filter variable to manifestsToRewrite for clarity. Co-Authored-By: Claude <noreply@anthropic.com>
Update the assertion to match the corrected semantics: rewritten_manifests_count == input manifest count, added_manifests_count == output manifest count (> 0). Co-Authored-By: Claude <noreply@anthropic.com>
The test expected compactManifest to change manifest file names, but with default settings the merge may be a no-op (same manifests, no new snapshot). Use a small manifest.target-file-size and manifest.full-compaction-file-size to force compactManifest to actually rewrite the manifests, making the stale manifestsBefore absent from the current base. Co-Authored-By: Claude <noreply@anthropic.com>
zhongyujiang
force-pushed
the
rewrite-manifest
branch
from
August 16, 2026 14:01
2b33320 to
960fbc2
Compare
Apache paimon master uses ManifestAvroWriter (not ManifestEntryWriter). Replace createManifestEntryWriter(Path) with createAvroWriter(Path), and use result().isEmpty() + abort() for empty manifest cleanup instead of recordCount() + path().getName(). Co-Authored-By: Claude <noreply@anthropic.com>
compactManifest may be a no-op (same manifests, no new snapshot) so the stale manifestsBefore stays in currentBase. Instead, manually rewrite the manifests to new files via manifestFile.write(), then replaceManifest — this changes file names, guaranteeing the subsequent replaceManifest with the stale manifestsBefore throws "Manifest conflict". Co-Authored-By: Claude <noreply@anthropic.com>
zhongyujiang
marked this pull request as ready for review
August 17, 2026 02:50
Contributor
Author
|
@JingsongLi Hi, can you help review this when you have time? I added this to sort manifest entries, which speeds up both scan and manifest commit a lot. |
zhongyujiang
commented
Aug 17, 2026
| procedureBuilders.put("reset_consumer", ResetConsumerProcedure::builder); | ||
| procedureBuilders.put("mark_partition_done", MarkPartitionDoneProcedure::builder); | ||
| procedureBuilders.put("compact_manifest", CompactManifestProcedure::builder); | ||
| procedureBuilders.put("rewrite_manifest", RewriteManifestProcedure::builder); |
Contributor
Author
There was a problem hiding this comment.
Added rewrite_manifest instead of reusing the old compact_manifest, since this operation does not necessarily produce a compaction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Manifest entries are written in commit order, which can become unordered over time. This makes ManifestFileMeta statistics (partitionStats / minBucket / maxBucket / minLevel / maxLevel) loose, reducing manifest-level pruning during scan.
This PR adds a rewrite_manifest Spark procedure that reads all manifest entries, sorts them globally by partition -> bucket -> level -> fileName (canceling ADD/DELETE pairs of the same file), and writes them back as new manifest files with compact statistics.
Usage
An optional where clause restricts the rewrite to manifests whose partition stats may match the predicate; the remaining manifests are left untouched.
Implementation
Tests