[core] Fix shared decompression buffer in stable manifest blocks - #9430
Merged
Conversation
yuzelin
force-pushed
the
fix-manifest-stable-block-buffer
branch
from
August 27, 2026 12:45
b62274b to
4c12aa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
ManifestAvroReader.RawBlock.stableCopy()copied the compressed Avro block but retained the original mutableDecoderContext. With ZSTD buffer reuse, decoding a stable previous block could overwrite the cached decompressed bytes of the current block. Reading the current block again could then fail with EOF/trailing-byte errors or silently decode incorrect content.This change gives every stable block an independent decoder context and decompression buffer.
Tests