[spark] Reject empty partition values for format tables - #9436
Merged
JingsongLi merged 1 commit intoAug 28, 2026
Merged
Conversation
sundapeng
force-pushed
the
upstream/format-table-reject-empty-partition
branch
from
August 28, 2026 03:41
1d06e4a to
335a482
Compare
sundapeng
changed the title
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Partition DDL accepted a string that names no partition. Paimon writes an empty or whitespace-only partition value to the default partition name, the same place a
NULLgoes.InternalRowPartitionComputerdecides that withStringUtils.isNullOrWhitespaceOnly. SoADD PARTITION (dt = '')registered a partition under a name its own value cannot round-trip to, andDROP PARTITION (dt = '')andTRUNCATE PARTITION (dt = '')silently hit the null partition and deleted its data.All three now reject such a value with an
IllegalArgumentExceptionnaming the column, the table and the default partition name. The whole batch is validated before anything is registered or created, so one bad spec fails without leaving the others half applied.NULLis untouched, and so is the write path: an empty value arriving throughINSERTstill lands in the default partition.Tests
CatalogManagedPartitionEdgeParityTest: 19 tests passed.