[format] Support sep as fallback key of csv.field-delimiter - #9565
Merged
Conversation
sep is Spark's option name for the CSV field delimiter, and the other fallback keys in CsvOptions already mirror Spark's CSV option names. Without it, setting sep is silently ignored and the delimiter falls back to the default comma.
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
csv.field-delimiteracceptsfield-delimiter,seqanddelimiteras fallback keys, but notsep. Settingsepis silently ignored and the delimiter falls back to the default,.The other fallback keys in
CsvOptionsmirror Spark's CSV option names one for one (lineSep,quote,escape,header,nullvalue,mode);sepis the only one missing. Same reason as #9170, which addeddelimiter.Tests
CsvFileFormatTest#testCsvFieldDelimiterFallbackKeys, extending the existing parameterized fallback-key list.Written with Claude Code; reasoning and verification are mine.