Conversation
Zizmor checks if the best practices are being used inside of the GitHub workflows
kevinjqliu
approved these changes
Sep 1, 2026
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM!
similar to the configs from https://github.com/apache/iceberg/blob/6a179f3128b162e7b12de748d9f79628924a4249/.github/workflows/zizmor.yml
it ran successfully for this PR too https://github.com/apache/parquet-format/actions/runs/33527299364/job/99921297615?pr=615
kevinjqliu
reviewed
Sep 1, 2026
| uses: zizmorcore/zizmor-action@3dc1ecc9bcb9e94e9b2c709687979e1298497054 # v0.6.2 | ||
| with: | ||
| advanced-security: false | ||
| min-severity: medium |
There was a problem hiding this comment.
Just a callout here: I think medium severity is a good trade off for signal to noise
Contributor
Author
There was a problem hiding this comment.
Thanks, let's start with medium then :)
wgtmac
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Zizmor checks if the best practices are being used inside of the GitHub workflows
What changes are included in this PR?
Do these changes have PoC implementations?