PARQUET-2199: Fix checkBlockSizeReached zero record size perf issue#1004
Open
songhuicheng wants to merge 1 commit into
Open
PARQUET-2199: Fix checkBlockSizeReached zero record size perf issue#1004songhuicheng wants to merge 1 commit into
songhuicheng wants to merge 1 commit into
Conversation
Parquet checks Block size after writing records to decide when it shall flush. This is relatively expensive, so it estimates the next check based on record size, record count etc. For small records less than 1byte after compression, the average record size is 0 after integer division. This caused overflow when calculating the next record count for block size check. It results in block size being checked for every record and slows down write. Fix the zero record size issue with float type record size.
|
This pull request has been automatically marked as stale because it has had no activity for at least 2 months. If you are still working on this change or plan to move it forward, please leave a comment or push a new commit so we know to keep it open. Otherwise, this PR will be closed automatically in about one month. Thank you for your contribution to Apache Parquet! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parquet checks Block size after writing records to decide when it shall flush. This is relatively expensive, so it estimates the next check based on record size, record count etc.
For small records less than 1byte after compression, the average record size is 0 after integer division. This caused overflow when calculating the next record count for block size check. It results in block size being checked for every record and slows down write.
Fix the zero record size issue with float type record size.
Make sure you have checked all steps below.