PARQUET-2245: Improve dictionary filter evaluating notEq#1029
Open
zhongyujiang wants to merge 1 commit into
Open
PARQUET-2245: Improve dictionary filter evaluating notEq#1029zhongyujiang wants to merge 1 commit into
zhongyujiang wants to merge 1 commit into
Conversation
wgtmac
reviewed
Feb 16, 2023
| || !meta.getStatistics().isNumNullsSet() | ||
| || meta.getStatistics().getNumNulls() > 0); | ||
| if (dictSet != null && dictSet.size() == 1 && dictSet.contains(value) && !mayContainNull) { | ||
| if (dictSet != null && dictSet.size() == 1 && dictSet.contains(value)) { |
Member
There was a problem hiding this comment.
I just noticed that the FilterPredicate does not provide an entry for IS NULL or IS NOT NULL. This confuses me because col IS NOT NULL is not equal to col != NULL.
CMIW, col NOT EQ A has two meanings as below:
- If A is NULL, it should return an empty list. Because NULL cannot be compared to any value including another NULL.
- Otherwise, it should return a list of values excluding A and NULL.
|
This pull request has been automatically marked as stale because it has had no activity for at least 2 months. If you are still working on this change or plan to move it forward, please leave a comment or push a new commit so we know to keep it open. Otherwise, this PR will be closed automatically in about one month. Thank you for your contribution to Apache Parquet! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: PARQUET-2245
This is a minor improvement for evaluating
notEq. When evaluatingnotEq, if the column may contain nulls and thenotEqvalue is non-null, the row-group must not be skipped. In such scenario reading dictionary and compare values is not necessary.