PARQUET-63: Enable dictionary encoding for FIXED. - #30
Closed
rdblue wants to merge 1 commit into
Closed
Conversation
rdblue
changed the title
Member
|
This looks good to me. However this is not forward compatible. |
This uses the existing dictionary support introduced for int96. Encoding and ParquetProperties have been updated to use the dictionary supporting classes, when requested for write or present during read. This also fixes a bug in the fixed dictionary values writer, where the length was hard-coded for int96, 12 bytes. Because writing dictionary-encoded fixed columns is not forward-compatible (older versions cannot read), the encoding will only be written for WriterVersion.PARQUET_2_0.
rdblue
force-pushed
the
PARQUET-63-add-fixed-dictionary-support
branch
from
September 3, 2014 23:30
ca59236 to
bc34a34
Compare
Contributor
Author
|
Added a check for |
tongjiechen
pushed a commit
to tongjiechen/incubator-parquet-mr
that referenced
this pull request
Oct 8, 2014
This uses the existing dictionary support introduced for int96. Encoding and ParquetProperties have been updated to use the dictionary supporting classes, when requested for write or present during read. This also fixes a bug in the fixed dictionary values writer, where the length was hard-coded for int96, 12 bytes. Author: Ryan Blue <rblue@cloudera.com> Closes apache#30 from rdblue/PARQUET-63-add-fixed-dictionary-support and squashes the following commits: bc34a34 [Ryan Blue] PARQUET-63: Enable dictionary encoding for FIXED.
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Feb 6, 2015
This uses the existing dictionary support introduced for int96. Encoding and ParquetProperties have been updated to use the dictionary supporting classes, when requested for write or present during read. This also fixes a bug in the fixed dictionary values writer, where the length was hard-coded for int96, 12 bytes. Author: Ryan Blue <rblue@cloudera.com> Closes apache#30 from rdblue/PARQUET-63-add-fixed-dictionary-support and squashes the following commits: bc34a34 [Ryan Blue] PARQUET-63: Enable dictionary encoding for FIXED.
sunchao
added a commit
to sunchao/parquet-mr
that referenced
this pull request
Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the existing dictionary support introduced for int96. Encoding
and ParquetProperties have been updated to use the dictionary supporting
classes, when requested for write or present during read. This also
fixes a bug in the fixed dictionary values writer, where the length was
hard-coded for int96, 12 bytes.