PARQUET-1992: Manually download interop files inside the test and move encryption interop test to maven integration-test phase - #878
Conversation
…run only when running verify (maven-failsafe-plugin integration-test goal). Download parquet-testing submodule only in integration-test profile.
… submodules folder.
gszadovszky
left a comment
gszadovszky
left a comment
There was a problem hiding this comment.
Thanks a lot for working on this. Sorry about the confusion that I did accept the idea of using git submodules before. Haven't realized it would cause issues with the tarball.
You've mentioned in the jira and in this PR as well that integration tests are executed in the phase verify and are not in the phases package/install. Based on the maven lifecycle install does depend on verify so the integration tests will be executed. It is not a problem and neither is that you have moved this test from unit tests to IT. Just wanted to mention.
| .cache | ||
| *~ | ||
| mvn_install.log | ||
| parquet-hadoop/parquet-testing |
There was a problem hiding this comment.
I would suggest using either a temporary directory outside of source tree or a place the files inside the target directory. target would have the benefit that it is not cleaned until explicitly invoked.
There was a problem hiding this comment.
Since you are using target now this change is unnecessary.
| .cache | ||
| *~ | ||
| mvn_install.log | ||
| parquet-hadoop/parquet-testing |
There was a problem hiding this comment.
Since you are using target now this change is unnecessary.
2 participants
This PR is another option of solving the problem "Cannot build from tarball because of git submodules".
mvn package- doesn't run interop testsmvn verify/install- run interop test and download files for interop from GitHub directly