fix PDF to Image conversion mis-rendered (PDFBOX-6232) - #521
Open
valerybokov wants to merge 1 commit into
Open
Conversation
Contributor
|
Thank you, I have asked the reporter to test this on his own files. I tested on mines and there are no regressions, but also no improvements on other files. However a reduced file (that I've just attached) that wasn't in my test set now comes up blank. But that file was already wrong before (flipped). That reduced file had so much reduced that it might be a different problem, I remember that I got carried away and had deleted the intermediate files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: PageDrawer.TransparencyGroup.getOrigin() decides how to position a luminosity soft mask using a single flipTG flag — flip-branch for masks applied directly, no-flip-branch for masks used inside a tiling pattern (the PDFBOX-5966 fix). That's wrong when the tiling pattern itself is used inside an enclosing transparency group (e.g. an isolated group): the enclosing group temporarily overwrites pageSize/xform to describe its own (already y-flipped) buffer, so the no-flip branch samples the mask at the wrong offset — the pattern's gradient collapses toward the backdrop color, producing the reported "hard-seamed horizontal bands."
Fix: use the flip branch whenever nested inside an enclosing transparency group (!transparencyGroupStack.isEmpty()), in addition to the existing !flipTG condition — one line plus an explanatory comment in PageDrawer.java.
See test: #520
Per https://www.apache.org/legal/generative-tooling.html: portions of this PR were
produced with assistance from Claude Code (Anthropic), based on a bug was described in Apache PDFBOX Issue Tracker.
I've reviewed the generated code and confirm to the best of my knowledge that the output does not include any
third-party copyrighted material and is compatible with the Apache License 2.0.