feat(stream): add supervisor strategy support to Throttle costCalculation#3108
Closed
He-Pin wants to merge 1 commit into
Closed
feat(stream): add supervisor strategy support to Throttle costCalculation#3108He-Pin wants to merge 1 commit into
He-Pin wants to merge 1 commit into
Conversation
…tion Motivation: The Throttle stage's costCalculation function had no exception handling. If the user-provided cost function threw, the exception propagated directly and failed the stage unconditionally. Unlike other stages (MapAsync, Filter, Log), Throttle did not consult the SupervisionStrategy decider, preventing users from configuring Resume or Restart behavior for bad elements. Modification: - Add try-catch around costCalculation(elem) with NonFatal handling - Add decider lookup via SupervisionStrategy mandatory attribute - On Stop: failStage (preserves default behavior) - On Resume/Restart: log at debug level and pull next element - Mix in StageLogging for observability - Add tests for Resume, Restart, Stop directives and Enforcing mode Result: Users can now configure supervision strategy on Throttle to skip elements that cause costCalculation exceptions, matching the behavior of other stages in Pekko Streams. Tests: - sbt "stream-tests / Test / testOnly org.apache.pekko.stream.scaladsl.FlowThrottleSpec" - 27 tests passed (4 new + 23 existing) References: Fixes apache#3101 Inspired by akkadotnet/akka.net#6886
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
Throttlestage'scostCalculationfunction had no exception handling. If the user-provided cost function threw, the exception propagated directly and failed the stage unconditionally. Unlike other stages (MapAsync,Filter,Log),Throttledid not consult theSupervisionStrategydecider, preventing users from configuring Resume or Restart behavior for bad elements.Fixes #3101
Modification
try-catcharoundcostCalculation(elem)withNonFatalhandlingdeciderlookup viaSupervisionStrategymandatory attributeStop:failStage(preserves default behavior)Resume/Restart: log at debug level andpullnext elementStageLoggingfor observabilityResult
Users can now configure supervision strategy on
Throttleto skip elements that causecostCalculationexceptions, matching the behavior of other stages in Pekko Streams.Tests
References
Fixes #3101