refactor: use String.formatted() instead of String.format()#3144
Merged
Conversation
Motivation: String.format(fmt, args) is a static method call. JDK 15 added String.formatted(args) as a fluent instance method on the format string. Modification: Replace 2 occurrences of String.format(fmt, args) with fmt.formatted(args): - UnsynchronizedByteArrayInputStream.java: range check error message - AeronErrorLog.java: Aeron error logging Result: More readable fluent API style, functionally identical. Tests: sbt "actor/compile" "remote/compile" — passed References: Refs #3136
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
String.format(fmt, args)is a static method call. JDK 15 addedString.formatted(args)as a fluent instance method on the format string itself.Modification
Replace 2 occurrences of
String.format(fmt, args)withfmt.formatted(args):UnsynchronizedByteArrayInputStream.java: range check error messageAeronErrorLog.java: Aeron error loggingResult
More readable fluent API style, functionally identical.
Tests
sbt "actor/compile" "remote/compile"— passedReferences
Refs #3136