Skip to content

perf: use Arrays.copyOf/copyOfRange instead of manual new Array + arraycopy #3150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
He-Pin merged 2 commits into from
Jun 23, 2026
Merged

perf: use Arrays.copyOf/copyOfRange instead of manual new Array + arraycopy #3150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb44456
perf: use Arrays.copyOf/copyOfRange instead of manual new Array + arr…
He-Pin Jun 23, 2026
bde32c8
fix: guard Arrays.copyOf against null _temp in ByteStringBuilder.resi…
He-Pin Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions actor/src/main/scala/org/apache/pekko/util/ByteString.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2728,8 +2728,7 @@ object CompactByteString {
val copyLength = Math.max(Math.min(array.length - copyOffset, length), 0)
if (copyLength == 0) empty
else {
val copyArray = new Array[Byte](copyLength)
System.arraycopy(array, copyOffset, copyArray, 0, copyLength)
val copyArray = java.util.Arrays.copyOfRange(array, copyOffset, copyOffset + copyLength)
ByteString.ByteString1C(copyArray)
}
}
Expand Down Expand Up @@ -2789,16 +2788,14 @@ final class ByteStringBuilder extends Builder[Byte, ByteString] {

private def clearTemp(): Unit = {
if (_tempLength > 0) {
val arr = new Array[Byte](_tempLength)
System.arraycopy(_temp, 0, arr, 0, _tempLength)
val arr = java.util.Arrays.copyOf(_temp, _tempLength)
_builder += ByteString1(arr)
_tempLength = 0
}
}

private def resizeTemp(size: Int): Unit = {
val newtemp = new Array[Byte](size)
if (_tempLength > 0) System.arraycopy(_temp, 0, newtemp, 0, _tempLength)
val newtemp = if (_temp eq null) new Array[Byte](size) else java.util.Arrays.copyOf(_temp, size)
_temp = newtemp
_tempCapacity = _temp.length
}
Expand Down
3 changes: 1 addition & 2 deletions ...stence/src/main/scala/org/apache/pekko/persistence/serialization/SnapshotSerializer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,7 @@ class SnapshotSerializer(val system: ExtendedActorSystem) extends BaseSerializer
val manifest =
if (remaining == 0) ""
else {
val manifestBytes = new Array[Byte](remaining)
System.arraycopy(bytes, 4, manifestBytes, 0, remaining)
val manifestBytes = java.util.Arrays.copyOfRange(bytes, 4, 4 + remaining)
migrateManifestToPekkoIfNecessary(new String(manifestBytes, UTF_8))
}
(serializerId, manifest)
Expand Down
3 changes: 1 addition & 2 deletions remote/src/main/scala/org/apache/pekko/remote/artery/ImmutableLongMap.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,7 @@ private[pekko] class ImmutableLongMap[A >: Null] private (private val keys: Arra
val i = Arrays.binarySearch(keys, key)
if (i >= 0) {
// existing key, replace value
val newValues = new Array[A](values.length)
System.arraycopy(values, 0, newValues, 0, values.length)
val newValues = values.clone()
newValues(i) = value
new ImmutableLongMap(keys, newValues)
} else {
Expand Down