test: cover async boundary failure draining#3296
Merged
Merged
Conversation
Motivation: Async boundary batching should preserve elements already produced by an upstream stage before that stage fails. Modification: Add a focused FusingSpec regression using transformed string elements upstream of an async boundary, then assert the already emitted elements arrive before the failure. Result: Async boundary failure-draining behavior has a direct regression test. Tests: - rtk scalafmt --mode diff-ref=origin/main -- passed - rtk scalafmt --list --mode diff-ref=origin/main -- passed - rtk git diff --check -- passed - rtk sbt "stream-tests / Test / testOnly org.apache.pekko.stream.FusingSpec -- -z \"deliver transformed elements already produced\"" -- passed, 1 test - rtk qodercli --help -- passed, confirmed -p/--print, --output-format, --cwd, and --attachment - qodercli stdout review of /tmp/project-review.diff -- passed, no must-fix findings References: None - regression coverage for async boundary batching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Async boundary batching should preserve elements already produced by an upstream stage before that stage fails.
Modification
Add a focused FusingSpec regression using transformed string elements upstream of an async boundary, then assert the already emitted elements arrive before the failure.
Result
Async boundary failure-draining behavior has a direct regression test.
References
None - regression coverage for async boundary batching