Clean up todos in traversal builder - #3371
Merged
Philippus merged 4 commits intoAug 5, 2026
Merged
Conversation
cannot use a linear builder, as it does not support later additions through the `add`-method
unclear how removing the cachedEmptyLinear has benefits
pjfanning
reviewed
Jul 20, 2026
`outOwners = outOwners - out` not being present in the else branch seems to be an omission
Philippus
force-pushed
the
clean-up-todos-in-traversal-builder
branch
from
July 20, 2026 18:33
2c078dd to
03ac475
Compare
Member
|
better with jmh numbers |
He-Pin
approved these changes
Jul 21, 2026
Member
|
Not sure about whether an additional map operation will reduce performance. |
He-Pin
requested changes
Jul 22, 2026
He-Pin
left a comment
He-Pin
left a comment
Member
There was a problem hiding this comment.
I think this will reduce some performance ? the code is correct.
Member
Author
|
Not sure why this would reduce performance? There are (almost) no code changes in this PR, also no additional map operations. |
Member
|
I agree with Philippus. This change doesn't look like it contains anything that affects performance. |
He-Pin
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.