Skip to content

PHOENIX-6752 Duplicate expression nodes in extract nodes during WHERE…#1469

Closed
gjacoby126 wants to merge 2 commits into
apache:masterfrom
gjacoby126:PHOENIX-6752-master
Closed

PHOENIX-6752 Duplicate expression nodes in extract nodes during WHERE…#1469
gjacoby126 wants to merge 2 commits into
apache:masterfrom
gjacoby126:PHOENIX-6752-master

Conversation

@gjacoby126

Copy link
Copy Markdown
Contributor

… compilation phase leads to poor performance

… compilation phase leads to poor performance
@gjacoby126
gjacoby126 requested a review from dbwong July 21, 2022 19:48
@gjacoby126

Copy link
Copy Markdown
Contributor Author

This is a rebase of #1467 since merging #1465 caused GitHub to incorrectly think there was a merge conflict there. (This is still @jpisaac 's code, I'm just doing it since he's out of office.) @dbwong and @tkhurana , you know the query parsing code better than me, so could you please take a look?

@gjacoby126

gjacoby126 commented Jul 22, 2022

Copy link
Copy Markdown
Contributor Author

This PR has caused InListIT to crash twice in the test environment, and InListIT is a test that it modifies. More investigation is needed before it can be merged. @jpisaac , @dbwong , @tkhurana , fyi.

… compilation phase leads to poor performance
@gjacoby126

Copy link
Copy Markdown
Contributor Author

@jpisaac - the new test in InListIT was causing OOMs during the iteration where it ran with 50,000 ORs (both in CI and locally). I tweaked it so it runs with at most 5000 ORs, and now it passes for me locally. If 50,000 ORs needs to be supported, either the test heap size needs to be bigger, or we need further optimization.

@gjacoby126

Copy link
Copy Markdown
Contributor Author

I'll let @jpisaac re-base his original PR now that he's back and close this one.

@gjacoby126 gjacoby126 closed this Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant