PHOENIX-6752 Duplicate expression nodes in extract nodes during WHERE…#1469
Closed
gjacoby126 wants to merge 2 commits into
Closed
PHOENIX-6752 Duplicate expression nodes in extract nodes during WHERE…#1469gjacoby126 wants to merge 2 commits into
gjacoby126 wants to merge 2 commits into
Conversation
… compilation phase leads to poor performance
Contributor
Author
Contributor
Author
… compilation phase leads to poor performance
Contributor
Author
|
@jpisaac - the new test in InListIT was causing OOMs during the iteration where it ran with 50,000 ORs (both in CI and locally). I tweaked it so it runs with at most 5000 ORs, and now it passes for me locally. If 50,000 ORs needs to be supported, either the test heap size needs to be bigger, or we need further optimization. |
Contributor
Author
|
I'll let @jpisaac re-base his original PR now that he's back and close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… compilation phase leads to poor performance