PHOENIX-6774 Enable code coverage reporting to SonarQube in Phoenix - #1491
Merged
Conversation
horvathdora
force-pushed
the
PHOENIX-6774
branch
from
August 22, 2022 15:15
ae5a3d4 to
eac5b2b
Compare
gjacoby126
approved these changes
Aug 22, 2022
gjacoby126
left a comment
gjacoby126
left a comment
Contributor
There was a problem hiding this comment.
+1, thanks @horvathdora
horvathdora
force-pushed
the
PHOENIX-6774
branch
from
August 23, 2022 07:33
eac5b2b to
96cca4c
Compare
| </build> | ||
| </profile> | ||
| <profile> | ||
| <id>sonar</id> |
Contributor
There was a problem hiding this comment.
Bit late but this profile should be called as 'codecoverage'
Or something else but consistent with the readme and most importantly the run-coverage.sh file.
Please create an addendum for this.
Contributor
Author
There was a problem hiding this comment.
We talked about it with @richardantal and it was a misunderstanding. The right profile is used in the script so no addendum needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.