Fix for flaky test ForwardIndexHandlerTest.testEnableDictionaryForMultipleColumns#10366
Merged
Jackie-Jiang merged 4 commits intoapache:masterfrom Mar 2, 2023
Merged
Fix for flaky test ForwardIndexHandlerTest.testEnableDictionaryForMultipleColumns#10366Jackie-Jiang merged 4 commits intoapache:masterfrom
Jackie-Jiang merged 4 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10366 +/- ##
=============================================
+ Coverage 13.76% 35.21% +21.44%
- Complexity 231 254 +23
=============================================
Files 1979 2033 +54
Lines 107729 110189 +2460
Branches 16457 16749 +292
=============================================
+ Hits 14831 38800 +23969
+ Misses 91717 68048 -23669
- Partials 1181 3341 +2160
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vvivekiyer
approved these changes
Mar 2, 2023
Contributor
vvivekiyer
left a comment
vvivekiyer
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing.
Jackie-Jiang
reviewed
Mar 2, 2023
| } while (FORWARD_INDEX_DISABLED_RAW_COLUMNS.contains(col1)); | ||
| indexLoadingConfig.getNoDictionaryColumns().remove(col1); | ||
| String col2 = _noDictionaryColumns.get(rand.nextInt(_noDictionaryColumns.size())); | ||
| String col2; |
Contributor
There was a problem hiding this comment.
Should we also ensure col2 is different from col1
Jackie-Jiang
approved these changes
Mar 2, 2023
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the quick fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the flaky test
ForwardIndexHandlerTest.testEnableDictionaryForMultipleColumnsas identified in issue: #10365Issue: Only forward index enabled columns should be used in this test, while due to choosing a random column a forward index disabled column can get picked sometimes.
Fix: Only pick forward index enabled columns
This also fixes a redundant if clause in
ForwardIndexHandlercc @Jackie-Jiang @vvivekiyer @siddharthteotia