Skip to content

Conversation

@somandal
Copy link
Contributor

Changing the _globalLock of BrokerRoutingManager to enable fairness to avoid writer starvation in case of high number of readers.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.57%. Comparing base (d1a3bb8) to head (848728f).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16932      +/-   ##
============================================
+ Coverage     63.47%   63.57%   +0.09%     
  Complexity     1411     1411              
============================================
  Files          3073     3073              
  Lines        180777   180777              
  Branches      27633    27633              
============================================
+ Hits         114755   114922     +167     
+ Misses        57174    56987     -187     
- Partials       8848     8868      +20     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.51% <100.00%> (+7.11%) ⬆️
java-21 63.49% <100.00%> (+0.03%) ⬆️
temurin 63.57% <100.00%> (+0.09%) ⬆️
unittests 63.56% <100.00%> (+0.09%) ⬆️
unittests1 56.45% <ø> (+0.01%) ⬆️
unittests2 33.68% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xiangfu0 xiangfu0 requested a review from Copilot September 30, 2025 19:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the BrokerRoutingManager to use a fair ReentrantReadWriteLock to prevent writer starvation when there are many concurrent readers accessing routing information.

  • Changes the _globalLock from a non-fair to a fair ReentrantReadWriteLock

@somandal somandal merged commit a7cad30 into apache:master Sep 30, 2025
35 of 36 checks passed
@somandal somandal deleted the broker-routing-manager-global-lock-fair branch September 30, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants