Skip to content

Change the globalLock of BrokerRoutingManager to be fair to prevent writer starvation #16932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
somandal merged 1 commit into from
Sep 30, 2025
Merged

Change the globalLock of BrokerRoutingManager to be fair to prevent writer starvation #16932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ public class BrokerRoutingManager implements RoutingManager, ClusterChangeHandle
// Global read-write lock for protecting the global data structures such as _enabledServerInstanceMap,
// _excludedServers, and _routableServers. Write lock must be held if any of these are modified, read lock must be
// held otherwise
private final ReadWriteLock _globalLock = new ReentrantReadWriteLock();
private final ReadWriteLock _globalLock = new ReentrantReadWriteLock(true);

// Per-table locks to allow concurrent routing builds across different tables while serializing per-table operations
// This must be keyed on the raw table name due to dependencies for TimeBoundaryManager creation between REALTIME
Expand Down