Skip to content

Add method createSegmentMessageHandlerFactory in BaseServerStarter#18298

Merged
xiangfu0 merged 1 commit into
apache:masterfrom
J-HowHuang:pluggable-segment-message-handler
Apr 23, 2026
Merged

Add method createSegmentMessageHandlerFactory in BaseServerStarter#18298
xiangfu0 merged 1 commit into
apache:masterfrom
J-HowHuang:pluggable-segment-message-handler

Conversation

@J-HowHuang
Copy link
Copy Markdown
Collaborator

Description

For any children class inheriting BaseServerStarter, this change allows it to override the method to provide customized message handler factory

Changes

  1. Add a new method createSegmentMessageHandlerFactory in BaseServerStarter to provide SegmentMessageHandlerFactory and register.
  2. Change the private variables in SegmentMessageHandlerFactory to protected

@J-HowHuang J-HowHuang added the plugins Related to the plugin system label Apr 23, 2026
@J-HowHuang J-HowHuang requested a review from Jackie-Jiang April 23, 2026 01:21
Copy link
Copy Markdown
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also allow creating custom StateModelFactory to make all Helix related handler pluggable

@J-HowHuang
Copy link
Copy Markdown
Collaborator Author

@Jackie-Jiang Do you want that to be in the same PR?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.60%. Comparing base (78e38eb) to head (e4cf14b).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
.../pinot/server/starter/helix/BaseServerStarter.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #18298      +/-   ##
============================================
+ Coverage     63.58%   63.60%   +0.02%     
  Complexity     1659     1659              
============================================
  Files          3245     3247       +2     
  Lines        197441   197482      +41     
  Branches      30564    30566       +2     
============================================
+ Hits         125536   125614      +78     
+ Misses        61856    61816      -40     
- Partials      10049    10052       +3     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.58% <0.00%> (+8.07%) ⬆️
java-21 63.57% <0.00%> (+<0.01%) ⬆️
temurin 63.60% <0.00%> (+0.02%) ⬆️
unittests 63.60% <0.00%> (+0.02%) ⬆️
unittests1 55.55% <ø> (+<0.01%) ⬆️
unittests2 35.07% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xiangfu0 xiangfu0 merged commit 73c89c7 into apache:master Apr 23, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugins Related to the plugin system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants