Add method createSegmentMessageHandlerFactory in BaseServerStarter#18298
Merged
xiangfu0 merged 1 commit intoApr 23, 2026
Merged
Conversation
Jackie-Jiang
approved these changes
Apr 23, 2026
Contributor
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Let's also allow creating custom StateModelFactory to make all Helix related handler pluggable
Collaborator
Author
|
@Jackie-Jiang Do you want that to be in the same PR? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18298 +/- ##
============================================
+ Coverage 63.58% 63.60% +0.02%
Complexity 1659 1659
============================================
Files 3245 3247 +2
Lines 197441 197482 +41
Branches 30564 30566 +2
============================================
+ Hits 125536 125614 +78
+ Misses 61856 61816 -40
- Partials 10049 10052 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For any children class inheriting
BaseServerStarter, this change allows it to override the method to provide customized message handler factoryChanges
createSegmentMessageHandlerFactoryinBaseServerStarterto provideSegmentMessageHandlerFactoryand register.SegmentMessageHandlerFactoryto protected