Add method createSegmentOnlineOfflineStateModelFactory in BaseServerStarter#18313
Merged
Conversation
| * Subclasses can override to return a custom factory. | ||
| */ | ||
| protected SegmentOnlineOfflineStateModelFactory createSegmentOnlineOfflineStateModelFactory( | ||
| InstanceDataManager instanceDataManager) { |
Contributor
There was a problem hiding this comment.
Let's also pass in _transitionThreadPoolManager. We can change the constructor of SegmentOnlineOfflineStateModelFactory to not take _instanceId and read it from instanceDataManager
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18313 +/- ##
============================================
+ Coverage 63.60% 63.61% +0.01%
Complexity 1659 1659
============================================
Files 3246 3246
Lines 197510 197514 +4
Branches 30578 30578
============================================
+ Hits 125620 125655 +35
+ Misses 61845 61818 -27
+ Partials 10045 10041 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jackie-Jiang
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Similar to #18298, making this change allows overriding with customized state model factory
Changes
createSegmentOnlineOfflineStateModelFactoryinBaseServerStarterto provideSegmentOnlineOfflineStateModelFactoryand register.SegmentOnlineOfflineStateModelFactoryto protected