Skip to content

Add method createSegmentOnlineOfflineStateModelFactory in BaseServerStarter #18313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jackie-Jiang merged 2 commits into from
Apr 24, 2026
Merged

Add method createSegmentOnlineOfflineStateModelFactory in BaseServerStarter #18313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26f0079
make state model factory pluggable
J-HowHuang Apr 23, 2026
7d9b803
change signature of create method and constructor
J-HowHuang Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,7 @@ public void start()

initSegmentFetcher(_serverConf);
StateModelFactory<?> stateModelFactory =
new SegmentOnlineOfflineStateModelFactory(_instanceId, instanceDataManager, _transitionThreadPoolManager);
createSegmentOnlineOfflineStateModelFactory(instanceDataManager, _transitionThreadPoolManager);
_helixManager.getStateMachineEngine()
.registerStateModelFactory(SegmentOnlineOfflineStateModelFactory.getStateModelName(), stateModelFactory);
// Start the data manager as a pre-connect callback so that it starts after connecting to the ZK in order to access
Expand Down Expand Up @@ -1264,6 +1264,15 @@ protected SegmentMessageHandlerFactory createSegmentMessageHandlerFactory(Instan
return new SegmentMessageHandlerFactory(instanceDataManager, serverMetrics);
}

/**
* Creates the {@link SegmentOnlineOfflineStateModelFactory} used to handle Helix state transitions for segments.
* Subclasses can override to return a custom factory.
*/
protected SegmentOnlineOfflineStateModelFactory createSegmentOnlineOfflineStateModelFactory(
InstanceDataManager instanceDataManager, StateTransitionThreadPoolManager transitionThreadPoolManager) {
return new SegmentOnlineOfflineStateModelFactory(instanceDataManager, transitionThreadPoolManager);
}

private void refreshMessageCount() {
try {
HelixDataAccessor dataAccessor = _helixManager.getHelixDataAccessor();
Expand Down
10 changes: 5 additions & 5 deletions ...ain/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,16 @@
*/
public class SegmentOnlineOfflineStateModelFactory extends StateModelFactory<StateModel> {

private final String _instanceId;
private final InstanceDataManager _instanceDataManager;
protected final String _instanceId;
protected final InstanceDataManager _instanceDataManager;
/** Provides custom thread pools for executing Helix state transition messages. If this is null, all state
* transition message will be executed using the default shared thread pool by Helix */
@Nullable
private final StateTransitionThreadPoolManager _stateTransitionThreadPoolManager;
protected final StateTransitionThreadPoolManager _stateTransitionThreadPoolManager;

public SegmentOnlineOfflineStateModelFactory(String instanceId, InstanceDataManager instanceDataManager,
public SegmentOnlineOfflineStateModelFactory(InstanceDataManager instanceDataManager,
@Nullable StateTransitionThreadPoolManager stateTransitionThreadPoolManager) {
_instanceId = instanceId;
_instanceId = instanceDataManager.getInstanceId();
_instanceDataManager = instanceDataManager;
_stateTransitionThreadPoolManager = stateTransitionThreadPoolManager;
}
Expand Down