Add spool query cases to multi-stage engine resource tests#18752
Merged
Conversation
Spool.json exercised a single spool shape (a table scanned once and joined twice). Add three more so the spool (useSpools) reuse path is covered across common patterns: - a stage reused by three downstream stages (one scan, three joins), - an aggregated stage reused by a self join, - an aggregated stage reused by both arms of a UNION ALL. Each query has an h2Sql equivalent, so results are validated against H2.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18752 +/- ##
============================================
- Coverage 64.67% 64.67% -0.01%
Complexity 1309 1309
============================================
Files 3381 3381
Lines 209821 209821
Branches 32805 32805
============================================
- Hits 135697 135692 -5
+ Misses 63230 63220 -10
- Partials 10894 10909 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
yashmayya
added
testing
yashmayya
approved these changes
Jun 12, 2026
cypherean
pushed a commit
to cypherean/pinot
that referenced
this pull request
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spool.jsonin the multi-stageResourceBasedQueriesTestpreviously covered a single spool shape (a table scanned once and joined twice). This adds three more so the spool (useSpools=true) reuse path is exercised across common reuse patterns:Each query has an
h2Sqlequivalent, so the results are validated against H2.Testing
mvn -pl pinot-query-runtime test -Dtest=ResourceBasedQueriesTest -Dpinot.fileFilter=Spool— all spool cases pass.