Consolidate pauseless ingestion failure tests - #19192
Closed
xiangfu0 wants to merge 2 commits into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19192 +/- ##
============================================
+ Coverage 66.62% 66.65% +0.02%
Complexity 1423 1423
============================================
Files 3443 3443
Lines 218626 218632 +6
Branches 34792 34793 +1
============================================
+ Hits 145662 145729 +67
+ Misses 61240 61181 -59
+ Partials 11724 11722 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Folded into #19190. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Each former concrete class started and stopped ZooKeeper, Kafka, controller, broker, and server, then republished the same 115,545 rows and rebuilt the same reference table.
In successful workflow run 31227570484, the four classes took 476.1 seconds combined:
The consolidated local class completed all four tests in 103.6 seconds. This is a directional comparison across different runners; this PR's Set 2 CI result will provide the apples-to-apples workflow measurement.
Correctness details
TableRebalancePauselessIntegrationTestremains dedicated and passes unchanged.Validation
./mvnw -pl pinot-integration-tests -am -Dtest=PauselessRealtimeIngestionIntegrationTest -Dsurefire.failIfNoSpecifiedTests=false test./mvnw -pl pinot-integration-tests -am -Dtest=TableRebalancePauselessIntegrationTest -Dsurefire.failIfNoSpecifiedTests=false test./mvnw spotless:apply -pl pinot-controller,pinot-integration-tests./mvnw license:format -pl pinot-controller,pinot-integration-tests./mvnw checkstyle:check -pl pinot-controller,pinot-integration-tests./mvnw license:check -pl pinot-controller,pinot-integration-tests