Surface recorded scheduling errors when assertNoTaskSchedule fails on null task names - #19389
Merged
Jackie-Jiang merged 1 commit intoAug 28, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19389 +/- ##
============================================
- Coverage 67.59% 67.57% -0.02%
Complexity 1430 1430
============================================
Files 3486 3486
Lines 224131 224131
Branches 35376 35376
============================================
- Hits 151497 151465 -32
- Misses 60608 60645 +37
+ Partials 12026 12021 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xiangfu0
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MinionTaskTestUtils.assertNoTaskScheduleassertsassertNotNull(info.getScheduledTaskNames())first, but null task names are the "no task scheduled due to scheduling errors" convention — and the actual cause is recorded in the info'sgenerationErrors/schedulingErrors, which the bare null assertion discards. A CI failure then reads onlyexpected object to not be null, and since several scheduling-failure branches record the error exclusively in the response (no WARN/ERROR log), the cause is unrecoverable from the run.This change folds both error lists into the assertion message, so a failure self-identifies:
Test-utility-only change; assertion semantics are unchanged.