Remove isIntermediateResultComparable method#7640
Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom Oct 26, 2021
Merged
Conversation
Jackie-Jiang
approved these changes
Oct 26, 2021
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
LGTM, thanks for the clean up
Codecov Report
@@ Coverage Diff @@
## master #7640 +/- ##
============================================
- Coverage 70.44% 65.26% -5.18%
+ Complexity 3999 3995 -4
============================================
Files 1575 1529 -46
Lines 79927 78051 -1876
Branches 11833 11633 -200
============================================
- Hits 56303 50942 -5361
- Misses 19773 23491 +3718
+ Partials 3851 3618 -233
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
|
Probably a semantic matter but this PR doesn't seem to deprecate the method but remove it entirely, could the PR title be changed to reflect that for anyone maintaining forks to follow along easier? |
Jackie-Jiang
changed the title
kriti-sc
pushed a commit
to kriti-sc/incubator-pinot
that referenced
this pull request
Dec 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove isIntermediateResultComparable method
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation