Remove isIntermediateResultComparable method

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunction.java

@@ -111,11 +111,6 @@ void aggregateGroupByMV(int length, int[][] groupKeysArray, GroupByResultHolder
    */
   IntermediateResult merge(IntermediateResult intermediateResult1, IntermediateResult intermediateResult2);
 
-  /**
-   * Returns whether the intermediate result is comparable.
-   */
-  boolean isIntermediateResultComparable();
-
   /**
    * Returns the {@link ColumnDataType} of the intermediate result.
    * <p>This column data type is used for transferring data in data table.

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AvgAggregationFunction.java

@@ -171,11 +171,6 @@ public AvgPair merge(AvgPair intermediateResult1, AvgPair intermediateResult2) {
     return intermediateResult1;
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return true;
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return ColumnDataType.OBJECT;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/CountAggregationFunction.java

@@ -140,11 +140,6 @@ public Long merge(Long intermediateResult1, Long intermediateResult2) {
     return intermediateResult1 + intermediateResult2;
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return true;
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return ColumnDataType.LONG;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctAggregationFunction.java

@@ -142,11 +142,6 @@ public Object merge(Object intermediateResult1, Object intermediateResult2) {
     throw new UnsupportedOperationException("Operation not supported for DISTINCT aggregation function");
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    throw new UnsupportedOperationException("Operation not supported for DISTINCT aggregation function");
-  }
-
   @Override
   public ColumnDataType getFinalResultColumnType() {
     throw new UnsupportedOperationException("Operation not supported for DISTINCT aggregation function");

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountAggregationFunction.java

@@ -294,11 +294,6 @@ public Set merge(Set intermediateResult1, Set intermediateResult2) {
     return intermediateResult1;
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return false;
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return ColumnDataType.OBJECT;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountBitmapAggregationFunction.java

@@ -309,11 +309,6 @@ public RoaringBitmap merge(RoaringBitmap intermediateResult1, RoaringBitmap inte
     return intermediateResult1;
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return false;
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return ColumnDataType.OBJECT;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountHLLAggregationFunction.java

@@ -306,11 +306,6 @@ public HyperLogLog merge(HyperLogLog intermediateResult1, HyperLogLog intermedia
     return intermediateResult1;
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return false;
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return ColumnDataType.OBJECT;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountRawHLLAggregationFunction.java

@@ -93,11 +93,6 @@ public HyperLogLog merge(HyperLogLog intermediateResult1, HyperLogLog intermedia
     return _distinctCountHLLAggregationFunction.merge(intermediateResult1, intermediateResult2);
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return _distinctCountHLLAggregationFunction.isIntermediateResultComparable();
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return _distinctCountHLLAggregationFunction.getIntermediateResultColumnType();

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java

@@ -976,11 +976,6 @@ public List<Sketch> merge(List<Sketch> sketches1, List<Sketch> sketches2) {
     return mergedSketches;
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return false;
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return ColumnDataType.OBJECT;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FastHLLAggregationFunction.java

@@ -163,11 +163,6 @@ public HyperLogLog merge(HyperLogLog intermediateResult1, HyperLogLog intermedia
     return intermediateResult1;
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return false;
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return ColumnDataType.OBJECT;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/IdSetAggregationFunction.java

@@ -468,11 +468,6 @@ public IdSet merge(IdSet intermediateResult1, IdSet intermediateResult2) {
     return IdSets.merge(intermediateResult1, intermediateResult2, _sizeThresholdInBytes, _expectedInsertions, _fpp);
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return false;
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return ColumnDataType.OBJECT;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/LastWithTimeAggregationFunction.java

@@ -210,11 +210,6 @@ public List<ExpressionContext> getInputExpressions() {
     return Arrays.asList(_expression, _timeCol);
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return false;
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return ColumnDataType.OBJECT;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MaxAggregationFunction.java

@@ -111,11 +111,6 @@ public Double merge(Double intermediateResult1, Double intermediateResult2) {
     }
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return true;
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return ColumnDataType.DOUBLE;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MinAggregationFunction.java

@@ -111,11 +111,6 @@ public Double merge(Double intermediateResult1, Double intermediateResult2) {
     }
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return true;
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return ColumnDataType.DOUBLE;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MinMaxRangeAggregationFunction.java

@@ -179,11 +179,6 @@ public MinMaxRangePair merge(MinMaxRangePair intermediateResult1, MinMaxRangePai
     return intermediateResult1;
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return true;
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return ColumnDataType.OBJECT;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/ModeAggregationFunction.java

@@ -454,11 +454,6 @@ public Map<? extends Number, Long> merge(Map<? extends Number, Long> intermediat
     return intermediateResult1;
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return false;
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return ColumnDataType.OBJECT;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/PercentileAggregationFunction.java

@@ -138,11 +138,6 @@ public DoubleArrayList merge(DoubleArrayList intermediateResult1, DoubleArrayLis
     return intermediateResult1;
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return false;
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return ColumnDataType.OBJECT;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/PercentileEstAggregationFunction.java

@@ -196,11 +196,6 @@ public QuantileDigest merge(QuantileDigest intermediateResult1, QuantileDigest i
     return intermediateResult1;
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return false;
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return ColumnDataType.OBJECT;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/PercentileRawEstAggregationFunction.java

@@ -119,11 +119,6 @@ public QuantileDigest merge(QuantileDigest intermediateResult1, QuantileDigest i
     return _percentileEstAggregationFunction.merge(intermediateResult1, intermediateResult2);
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return _percentileEstAggregationFunction.isIntermediateResultComparable();
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return _percentileEstAggregationFunction.getIntermediateResultColumnType();

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/PercentileRawTDigestAggregationFunction.java

@@ -120,11 +120,6 @@ public TDigest merge(TDigest intermediateResult1, TDigest intermediateResult2) {
     return _percentileTDigestAggregationFunction.merge(intermediateResult1, intermediateResult2);
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return _percentileTDigestAggregationFunction.isIntermediateResultComparable();
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return _percentileTDigestAggregationFunction.getIntermediateResultColumnType();

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/PercentileTDigestAggregationFunction.java

@@ -199,11 +199,6 @@ public TDigest merge(TDigest intermediateResult1, TDigest intermediateResult2) {
     return intermediateResult1;
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return false;
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return ColumnDataType.OBJECT;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/SegmentPartitionedDistinctCountAggregationFunction.java

@@ -312,11 +312,6 @@ public Long merge(Long intermediateResult1, Long intermediateResult2) {
     return intermediateResult1 + intermediateResult2;
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return true;
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return ColumnDataType.LONG;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/StUnionAggregationFunction.java

@@ -113,11 +113,6 @@ public Geometry merge(Geometry intermediateResult1, Geometry intermediateResult2
     return intermediateResult1.union(intermediateResult2);
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return false;
-  }
-
   @Override
   public DataSchema.ColumnDataType getIntermediateResultColumnType() {
     return DataSchema.ColumnDataType.OBJECT;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/SumAggregationFunction.java

@@ -99,11 +99,6 @@ public Double merge(Double intermediateResult1, Double intermediateResult2) {
     return intermediateResult1 + intermediateResult2;
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return true;
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return ColumnDataType.DOUBLE;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/SumPrecisionAggregationFunction.java

@@ -239,11 +239,6 @@ public BigDecimal merge(BigDecimal intermediateResult1, BigDecimal intermediateR
     return intermediateResult1.add(intermediateResult2);
   }
 
-  @Override
-  public boolean isIntermediateResultComparable() {
-    return true;
-  }
-
   @Override
   public ColumnDataType getIntermediateResultColumnType() {
     return ColumnDataType.OBJECT;

pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/AggregationGroupByTrimmingService.java

@@ -82,7 +82,8 @@ public List<Map<String, Object>> trimIntermediateResultsMap(Map<String, Object[]
       Sorter[] sorters = new Sorter[numAggregationFunctions];
       for (int i = 0; i < numAggregationFunctions; i++) {
         AggregationFunction aggregationFunction = _aggregationFunctions[i];
-        sorters[i] = getSorter(_trimSize, aggregationFunction, aggregationFunction.isIntermediateResultComparable());
+        // Assume the intermediate result may not be comparable.
+        sorters[i] = getSorter(_trimSize, aggregationFunction, false);
       }
 
       // Add results into sorters