Skip to content

enable tests with rounding errors [MINOR]#9880

Closed
agavra wants to merge 2 commits intoapache:masterfrom
agavra:agg-tests
Closed

enable tests with rounding errors [MINOR]#9880
agavra wants to merge 2 commits intoapache:masterfrom
agavra:agg-tests

Conversation

@agavra
Copy link
Copy Markdown
Contributor

@agavra agavra commented Nov 30, 2022

reformat the Aggregates.json test and enable the tests with rounding errors, just divide by 2 to make sure the ints round to the same value.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 2, 2022

Codecov Report

Merging #9880 (af5e981) into master (716797f) will increase coverage by 3.13%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9880      +/-   ##
============================================
+ Coverage     24.94%   28.08%   +3.13%     
- Complexity       44       53       +9     
============================================
  Files          1966     1966              
  Lines        105835   105835              
  Branches      16056    16056              
============================================
+ Hits          26404    29720    +3316     
+ Misses        76743    73183    -3560     
- Partials       2688     2932     +244     
Flag Coverage Δ
integration1 25.13% <ø> (+0.18%) ⬆️
integration2 24.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mmon/request/context/predicate/NotEqPredicate.java 61.53% <0.00%> (-15.39%) ⬇️
...ache/pinot/core/operator/docidsets/OrDocIdSet.java 86.36% <0.00%> (-13.64%) ⬇️
.../pinot/common/function/scalar/ObjectFunctions.java 7.69% <0.00%> (-7.70%) ⬇️
...inot/core/util/SegmentCompletionProtocolUtils.java 50.00% <0.00%> (-7.70%) ⬇️
...pache/pinot/core/query/optimizer/filter/Range.java 87.75% <0.00%> (-4.09%) ⬇️
.../helix/core/realtime/SegmentCompletionManager.java 43.29% <0.00%> (-2.44%) ⬇️
.../org/apache/pinot/core/startree/StarTreeUtils.java 44.32% <0.00%> (-2.07%) ⬇️
...perator/filter/SortedIndexBasedFilterOperator.java 71.42% <0.00%> (-1.91%) ⬇️
...ery/optimizer/filter/MergeEqInFilterOptimizer.java 88.88% <0.00%> (-1.24%) ⬇️
...nction/DistinctCountBitmapAggregationFunction.java 48.70% <0.00%> (-1.04%) ⬇️
... and 229 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@agavra agavra closed this Dec 5, 2022
@agavra agavra deleted the agg-tests branch December 5, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants