Skip to content

enable tests with rounding errors [MINOR] #9880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agavra wants to merge 2 commits into from
Closed

enable tests with rounding errors [MINOR] #9880

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d506e14
enable tests with rounding errors
agavra Nov 30, 2022
af5e981
Merge branch 'master' into agg-tests
agavra Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions pinot-query-runtime/src/test/resources/queries/Aggregates.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,10 @@
},
"queries": [
{
"ignored": true,
"psql": "4.2.7",
"comments": "result error:average doesn't work because we round up but h2 round down for integer",
"comments": ":we round up but h2 round down for integer, to work around this we divide by 2",
"description": "average int",
"sql": "SELECT avg(int_col) FROM {tbl}"
"sql": "SELECT avg(int_col) / 2 FROM {tbl}"
},
{
"psql": "4.2.7",
Expand Down Expand Up @@ -173,10 +172,9 @@
},
{
"psql": "4.2.7",
"ignored": true,
"description": "aggregate int column and filter by int column",
"comments": "rounding error",
"sql": "SELECT sum(1 /int_col) FROM {tbl} WHERE int_col > 0"
"comments": "divide result by 2 to avoid rounding error",
"sql": "SELECT sum(1 /int_col) / 2 FROM {tbl} WHERE int_col > 0"
},
{
"psql": "4.2.7",
Expand Down