Support theme colors as highlight color in pptx. - #1174
Merged
Conversation
Although the PowerPoint UI doesn't allow it, it's possible to use a theme color for text highlight. Some external software seems to do it, and PowerPoint displays the highlight correctly. In POI we expected the highlight color to always be srgbClr, or return null. In POI 5.5.x it was even a crash, the null check was added later. We change fetchHighlightColor to use XSLFColor to determine the color instead of reading the RGB directly. That class supports the different XML tags that implement colors in OOXML.
jaragunde
marked this pull request as ready for review
July 2, 2026 15:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although the PowerPoint UI doesn't allow it, it's possible to use a theme color for text highlight. Some external software seems to do it, and PowerPoint displays the highlight correctly.
In POI we expected the highlight color to always be srgbClr, or return null. In POI 5.5.x it was even a crash, the null check was added later.
We change fetchHighlightColor to use XSLFColor to determine the color instead of reading the RGB directly. That class supports the different XML tags that implement colors in OOXML.