Disable cloud storage tests that would use @TempDir #3095
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disables 5 view catalog tests for cloud storage providers (S3, ADLS, GCS) that use
@TempDir. TheViewCatalogTestsbase class usesPaths.get()with the temp directory, which doesn't support cloud storage paths.Follow-up to #2871.
Background
These tests inherit from Iceberg's
ViewCatalogTests, which passes a@TempDirpath toPaths.get(). SincePaths.get()only accepts local filesystem paths, it cannot handle cloud storage URIs. For example, when@TempDirprovides/tmp/junit123,Paths.get()converts it to a URI likefile:///tmp/junit123. But for cloud storage base paths likes3://bucket/path, it would incorrectly creates3:/bucket/path(single slash) instead of the valids3://bucket/pathformat.These tests are disabled to prevent false positives - they would pass by testing against local filesystem instead of actually validating cloud storage behavior.
Changes
Base test classes - Added
@Disabledoverrides for 5 tests:PolarisRestCatalogViewAdlsIntegrationTestBase.javaPolarisRestCatalogViewGcsIntegrationTestBase.javaPolarisRestCatalogViewS3IntegrationTestBase.javaConcrete test classes - Removed reflection workaround:
RestCatalogViewAdlsIT.javaRestCatalogViewGcsIT.javaRestCatalogViewS3IT.javaTesting
Run cloud tests:
./gradlew cloudTestFuture Work
Will follow up with changes to Iceberg's
ViewCatalogTeststo avoid usingPaths.get()with@TempDir. Once that's done, these tests can be re-enabled.