Skip to content

Fix retry logic for table commits in CatalogHandlerUtils#4748

Merged
flyrain merged 2 commits into
apache:mainfrom
ayushtkn:4747
Jun 17, 2026
Merged

Fix retry logic for table commits in CatalogHandlerUtils#4748
flyrain merged 2 commits into
apache:mainfrom
ayushtkn:4747

Conversation

@ayushtkn

Copy link
Copy Markdown
Member

Fixes: #4747

Checklist

  • 🛡️ Don't disclose security issues! (contact security@apache.org)
  • 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
  • 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
  • 💡 Added comments for complex logic
  • 🧾 Updated CHANGELOG.md (if needed)
  • 📚 Updated documentation in site/content/in-dev/unreleased (if needed)

Copilot AI review requested due to automatic review settings June 13, 2026 22:46
@github-project-automation github-project-automation Bot moved this to PRs In Progress in Basic Kanban Board Jun 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adjusts commit retry behavior to ensure table metadata is refreshed when the commit operation is retried.

Changes:

  • Marks the operation as having attempted once so subsequent retries use refresh() rather than current().

adutra
adutra previously approved these changes Jun 15, 2026
@github-project-automation github-project-automation Bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Jun 15, 2026

@flyrain flyrain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix, @ayushtkn ! Can we add a test to avoid regression?

@flyrain flyrain merged commit 6382476 into apache:main Jun 17, 2026
24 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to merge to Done in Basic Kanban Board Jun 17, 2026
@flyrain

flyrain commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Thanks @ayushtkn for the fix, Thanks @dimas-b @adutra for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix retry logic for table commits

5 participants