Redact access token from PolarisCredential toString#4752
Closed
vigneshio wants to merge 1 commit into
Closed
Conversation
adutra
reviewed
Jun 15, 2026
| import java.util.Set; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class PolarisCredentialTest { |
Contributor
There was a problem hiding this comment.
I would remove this test. It's actually testing the Java Immutables library, not Polaris code.
vigneshio
force-pushed
the
fix-token-redaction-in-logs
branch
from
June 15, 2026 13:15
6c514cf to
f0d25ea
Compare
DefaultAuthenticator logs PolarisCredential at DEBUG and WARN; toString() previously included the raw bearer token. Add @Value.Redacted on getToken(), matching PolarisPrincipal.
vigneshio
force-pushed
the
fix-token-redaction-in-logs
branch
from
June 15, 2026 13:17
f0d25ea to
666c836
Compare
github-project-automation
Bot
moved this from PRs In Progress
to Done
in Basic Kanban Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultAuthenticatorlogsPolarisCredentialat DEBUG and WARN (including on failed principal resolution). ImmutablestoString()previously included the raw bearer token.Add
@Value.RedactedongetToken(), matching the existing pattern onPolarisPrincipal.getToken(). Programmatic access is unchanged; only log output is affected.Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)