Skip to content

Remove dead commented S3 client code from MinioContainer and RustfsContainer#4840

Merged
dimas-b merged 1 commit into
apache:mainfrom
venkateshwaracholan:issue-4839-remove-dead-s3-comments
Jun 19, 2026
Merged

Remove dead commented S3 client code from MinioContainer and RustfsContainer#4840
dimas-b merged 1 commit into
apache:mainfrom
venkateshwaracholan:issue-4839-remove-dead-s3-comments

Conversation

@venkateshwaracholan

Copy link
Copy Markdown
Contributor

Summary

This PR removes a few outdated commented-out lines from the createS3Client() implementations in both MinioContainer and RustfsContainer.

The comments appear to be leftovers from earlier Nessie-related S3 client configuration code that is no longer used. Because they do not reflect the current implementation, they can create confusion for contributors reading the code and make the methods appear more complex than they actually are.

By removing these obsolete comments, the code becomes easier to read and maintain while keeping the implementation focused on the active logic.

Changes

  • Removed obsolete commented-out S3 client configuration code from MinioContainer#createS3Client().
  • Removed the same obsolete comments from RustfsContainer#createS3Client().
  • No executable code was changed.
  • No functional or behavioral changes were introduced.

Checklist

@github-project-automation github-project-automation Bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Jun 19, 2026
@dimas-b dimas-b merged commit bf11263 into apache:main Jun 19, 2026
24 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to merge to Done in Basic Kanban Board Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dead commented S3 client code from MinioContainer and RustfsContainer

3 participants