Remove dead commented S3 client code from MinioContainer and RustfsContainer#4840
Merged
dimas-b merged 1 commit intoJun 19, 2026
Merged
Conversation
nandorKollar
approved these changes
Jun 19, 2026
dimas-b
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes a few outdated commented-out lines from the
createS3Client()implementations in bothMinioContainerandRustfsContainer.The comments appear to be leftovers from earlier Nessie-related S3 client configuration code that is no longer used. Because they do not reflect the current implementation, they can create confusion for contributors reading the code and make the methods appear more complex than they actually are.
By removing these obsolete comments, the code becomes easier to read and maintain while keeping the implementation focused on the active logic.
Changes
MinioContainer#createS3Client().RustfsContainer#createS3Client().Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)