Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

Conversation

@chanlee514
Copy link
Contributor

No description provided.

Copy link
Contributor

@dszeto dszeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other stuff LGTM.

data.versions.pio %>/apache-predictionio-<%= data.versions.pio %>.tar.gz).

Verify this release using [signatures and checksums](https://www.apache.org/
dist/incubator/predictionio/0.12.0-incubating/) and [project release KEYS](
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using data.versions.pio instead?

Verify this release using [signatures and checksums](https://www.apache.org/
dist/incubator/predictionio/0.12.0-incubating/) and [project release KEYS](
https://www.apache.org/dist/incubator/predictionio/KEYS). Refer to
[instructions](http://httpd.apache.org/download.cgi#verify) on how to verify.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to copy those instructions over.

Copy link
Contributor

@dszeto dszeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @chanlee514!

@asfgit asfgit closed this in 5f8a0c9 Oct 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants