fix: return error when the client transaction coordinator is nil to p… #1444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the Pulsar client is created, if
EnableTransactionistruethen the transaction coordinator client is created.If an application tries to create a transaction with
NewTransaction()whenEnableTransactionisfalse, the application will panic; returning an error when the transaction coordinator isnilwill prevent this.Modifications
In
NewTransaction(), a nil check is added . If the transaction coordination client isnil, the method now returns an error.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation