[improve][ci] Run the integrationTest source set in CI#74
Merged
david-streamlio merged 1 commit intoJul 9, 2026
Merged
Conversation
The mqtt module ships a Testcontainers integration test in a separate integrationTest source set, added alongside the connector in apache#22. The CI workflow only invokes the test task, so that test has never run on a pull request and its coverage was not enforced. Add integrationTest to the tests matrix. The task currently resolves to mqtt only; other modules keep their container tests in src/test.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions CI workflow so the repository’s existing integrationTest Gradle source set (notably :mqtt:integrationTest) is exercised on pull requests, closing a gap where container-based MQTT E2E coverage was present but not enforced.
Changes:
- Extend the CI tests matrix for the “Connectors” job to run
integrationTestin addition totest. - Ensure CI failure artifacts collection continues to capture test reports (including integration test reports).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
david-streamlio
added a commit
that referenced
this pull request
Jul 10, 2026
…not hang CI (#91) The Mosquitto GenericContainer had no wait strategy and no startup timeout, so a stalled image pull hung @BeforeClass with no bound and took the whole Tests - Connectors job to its 45-minute limit — a cancellation rather than a failure, with no diagnostics. Observed on run 29100595779. Add Wait.forListeningPort() with a 3-minute startup timeout, plus a test-level timeOut backstop. An unsatisfiable startup now fails in about 20s with ContainerLaunchException instead of hanging. This test only began running in CI when #74 added integrationTest to the matrix, so the hazard was newly live.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
mqttmodule ships a real Testcontainers integration test —MqttSinkIntegrationTest, added alongside the connector in #22 — in a separateintegrationTestsource set, with its ownintegrationTestGradle task.The CI workflow's tests matrix only runs
test:So that integration test has never run on a pull request. The coverage exists but is not enforced: a change that broke MQTT delivery would go green.
This was found while auditing connectors for missing integration tests (#55). Every other module keeps its container tests in
src/test, where CI picks them up;mqttis the sole module with a separate source set.Modifications
Add
integrationTestto the matrix tasks. Verified that the task resolves repo-wide —./gradlew integrationTest --dry-runsucceeds, currently selecting only:mqtt:integrationTest.Keeping the source set (rather than moving the test into
src/test) preserves whatever intent led to the split, and leaves room for other modules to separate slow container tests from fast unit tests later.Verifying this change
The test was also mutation-checked: publishing to a different topic than the subscriber listens on makes it fail, so it genuinely guards delivery rather than passing against a broken target.
Note
This adds container-based work to the per-PR job.
:mqtt:integrationTesttakes ~18s locally, so the impact is small, but it is worth being explicit that theTests - Connectorsjob now starts a Mosquitto container.