Fix delete namespace with 'Cannot delete non empty bundle' issue.#13337
Fix delete namespace with 'Cannot delete non empty bundle' issue.#13337Technoboy- wants to merge 5 commits intoapache:masterfrom
Conversation
|
/pulsarbot run-failure-checks |
|
@Technoboy- This may be should not skip the system topic check here, I test it. There maybe problems.
I debugged the code. In fact, an try to delete the system topic when deleting the namespace. But Internal consumers and producers will reconnect, resulting in the auto create of the topic. Should we shut down these internal consumers(and producers) first? Ensure that the system topic is deleted correctly before deleting the bundle? Or directly redirect For your reference, If there is a problem, we can continue to discuss it, thanks. |
Thanks first,I will re-check it and respond later. |
codelipenghui
left a comment
There was a problem hiding this comment.
When deleting a namespace, we need to close the reader of the system topic first, and then delete the system topic, finally delete the namespace.
a13b81a to
e28e977
Compare
|
Hi , @shibd . |
|
@Technoboy- Yes,Execute not orderly is one of the problems. But
I tested your code, but I still can't delete the namespace correctly. I think it may be related to the above two reasons. PTAL. |
Yes, really, I will update later. |
036d6c5 to
17f2125
Compare
|
/pulsarbot run-failure-checks |
...ker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java
Outdated
Show resolved
Hide resolved
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
Outdated
Show resolved
Hide resolved
9b2280d to
6af0293
Compare
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
|
/pulsarbot rerun-failure-checks |
|
@shibd Could you please help review this PR again? |
|
Emm,I running in standalone mode, I tested the latest code and still have some problems.
I thought about it, Now, after terminate the topic, only the producer connection will be rejected, the consumer can still connect and consume, and the topic will still trigger automatic creation. |
|
Hi, @Technoboy- , could you take a look at the @shibd 's comments? |
Yes, we may need some other solution for it. |
|
Removing release label and milestone since the PR is closed. Please re-add if we need to open the PR. |


Fix #10263.
Motivation
When there are no user-created topics under a namespace, Namespace should be deleted. But currently, system topic existed and reader/producer could auto-create system and may cause the namespace deletion to fail.
Modifications
Documentation
Need to update docs?
no-need-doc