[pulsar-client-admin]: reduce code duplication in TopicsImpl#13388
Merged
codelipenghui merged 1 commit intoapache:masterfrom Dec 21, 2021
Merged
[pulsar-client-admin]: reduce code duplication in TopicsImpl#13388codelipenghui merged 1 commit intoapache:masterfrom
codelipenghui merged 1 commit intoapache:masterfrom
Conversation
HQebupt
force-pushed
the
cleanUp
branch
3 times, most recently
from
1b676d2 to
a363baf
Compare
hezhangjian
approved these changes
Dec 19, 2021
AnonHxy
approved these changes
Dec 19, 2021
codelipenghui
approved these changes
Dec 21, 2021
1 task
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
Dec 21, 2021
- align with recent refactoring apache#13388
lhotari
added a commit
that referenced
this pull request
Dec 21, 2021
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Dec 29, 2021
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Dec 29, 2021
- align with recent refactoring apache#13388
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TopicsImplcontains lots of code duplication. So do a clean up.Modifications
Refer: #13086 @eolivelli
use
sync()to reduce code duplication.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-doc(Just code clean up)