[Fix][Transaction] Optimize log when create transaction systemTopic#14911
Closed
liangyepianzhou wants to merge 1 commit intoapache:masterfrom
liangyepianzhou:optimize_log_create_txn_systemTopic
Closed
[Fix][Transaction] Optimize log when create transaction systemTopic#14911liangyepianzhou wants to merge 1 commit intoapache:masterfrom liangyepianzhou:optimize_log_create_txn_systemTopic
liangyepianzhou wants to merge 1 commit intoapache:masterfrom
liangyepianzhou:optimize_log_create_txn_systemTopic
Conversation
### Motivation When users use admin to get status of transaction system topic,they will get a confused error ### Modification Optimize the error msg
Technoboy-
reviewed
Mar 28, 2022
| if (isTransactionSystemTopic(topicName)) { | ||
| String msg = String.format("Can not create transaction system topic %s", topic); | ||
| String msg = String.format("Only has metadata, used for transactionCoordinator load balance, " | ||
| + "never need to be created, for transaction system topic %s", topic); |
Contributor
There was a problem hiding this comment.
Ah...it's funny.
@Anonymitaet Could you help review this?
Member
There was a problem hiding this comment.
@liangyepianzhou Sorry, I don't quite understand the meaning. Could you please explain a bit more?
Contributor
Author
There was a problem hiding this comment.
Of course, the current situation is that we have some system topics for lookup that only need to create metadata.
Then the user used admin to query this topic, but our error made the user confused and raised the issue.
Contributor
There was a problem hiding this comment.
Ignore creation of transaction system topic, no need to create. @Anonymitaet. I think the meaning is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #14790
Motivation
When users use admin to get status of transaction system topic,they will get a confused error.
Modification
Optimize the error msg.
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)