Skip to content

[Fix][Transaction] Optimize log when create transaction systemTopic #14911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liangyepianzhou wants to merge 1 commit into from
Closed

[Fix][Transaction] Optimize log when create transaction systemTopic #14911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1376,7 +1376,8 @@ private void createPersistentTopic(final String topic, boolean createIfMissing,
}

if (isTransactionSystemTopic(topicName)) {
String msg = String.format("Can not create transaction system topic %s", topic);
String msg = String.format("Only has metadata, used for transactionCoordinator load balance, "
+ "never need to be created, for transaction system topic %s", topic);
Copy link
Contributor

@Technoboy- Technoboy- Mar 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah...it's funny.
@Anonymitaet Could you help review this?

Copy link
Member

@Anonymitaet Anonymitaet Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liangyepianzhou Sorry, I don't quite understand the meaning. Could you please explain a bit more?

Copy link
Contributor Author

@liangyepianzhou liangyepianzhou Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, the current situation is that we have some system topics for lookup that only need to create metadata.
Then the user used admin to query this topic, but our error made the user confused and raised the issue.

Copy link
Contributor

@gaozhangmin gaozhangmin Mar 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore creation of transaction system topic, no need to create. @Anonymitaet. I think the meaning is.

log.warn(msg);
pulsar.getExecutor().execute(() -> topics.remove(topic, topicFuture));
topicFuture.completeExceptionally(new NotAllowedException(msg));
Expand Down
6 changes: 4 additions & 2 deletions pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,15 +158,17 @@ public void testCreateTransactionSystemTopic() throws Exception {
Consumer<byte[]> consumer = getConsumer(topicName, subName);
fail();
} catch (PulsarClientException.NotAllowedException e) {
assertTrue(e.getMessage().contains("Can not create transaction system topic"));
assertTrue(e.getMessage().contains("Only has metadata, used for transactionCoordinator load balance, "
+ "never need to be created, for transaction system topic "));
}

// can't create transaction system topic
try {
admin.topics().getSubscriptions(topicName);
fail();
} catch (PulsarAdminException e) {
assertEquals(e.getMessage(), "Can not create transaction system topic " + topicName);
assertEquals(e.getMessage(), "Only has metadata, used for transactionCoordinator load balance, "
+ "never need to be created, for transaction system topic " + topicName);
}

// can't create transaction system topic
Expand Down