-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Fix logger lever from warn to debug when uancked threshold is limited #14950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: xiaolongran <xiaolongran@tencent.com>
Signed-off-by: xiaolongran <xiaolongran@tencent.com>
|
I believe in this case the log should really be at debug level. The information is already available in the topic stats for debugging purposes. |
Yes, when the unack reaches the maximum threshold, we can get the number of unackedMessages through |
|
ping @merlimat @codelipenghui @hangc0276 @315157973 PTAL thanks |
|
Which approach do we prefer here:
|
|
IMO,we'd better change the log level from warn to debug, and can get the unack info from topic stats. |
OK i will fix this change |
Signed-off-by: xiaolongran <xiaolongran@tencent.com>
|
ping @merlimat @codelipenghui @hangc0276 @315157973 PTAL thanks |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
…apache#14950) * Add rate logger for repo Signed-off-by: xiaolongran <xiaolongran@tencent.com> * fix log info Signed-off-by: xiaolongran <xiaolongran@tencent.com> * fix comments Signed-off-by: xiaolongran <xiaolongran@tencent.com>
…apache#14950) * Add rate logger for repo Signed-off-by: xiaolongran <xiaolongran@tencent.com> * fix log info Signed-off-by: xiaolongran <xiaolongran@tencent.com> * fix comments Signed-off-by: xiaolongran <xiaolongran@tencent.com>
|
I've open a follow up PR #15767 to change other log lines, PTAL. |
Signed-off-by: xiaolongran xiaolongran@tencent.com
Motivation
When unacked messages reached to max unacked messages, the following logs will be quickly output to the log file, causing the broker's log file to switch within a short period of time.
Modifications
Fix logger lever from warn to debug when uancked threshold is limited