[pulsar-broker] Change dispatcher blocked/unblocked log level to debug #15767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
michaeljmarshall
approved these changes
May 25, 2022
michaeljmarshall
added
the
type/cleanup
michaeljmarshall
requested review from
MarvinCai,
eolivelli,
lhotari,
merlimat and
wolfstudy
RobertIndie
approved these changes
May 25, 2022
codelipenghui
approved these changes
May 26, 2022
k2la
approved these changes
Jun 12, 2022
|
The pr had no activity for 30 days, mark with Stale label. |
Member
|
I don't see a way to retrigger tests for some reason. Closing and reopening. |
Member
|
@Shawyeok - looks like there are merge conflicts now. Are you able to resolve those? Thanks. |
tisonkun
reviewed
Aug 10, 2022
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
log.debug already logs only if debug or lower level set. Since the log parameters are all simple access instead of heavy supplier, I tend to regard this change as redundant.
Shawyeok
force-pushed
the
change-dispatcher-log
branch
from
e784c24 to
59977a0
Compare
Shawyeok
force-pushed
the
change-dispatcher-log
branch
from
59977a0 to
31c4d01
Compare
Contributor
Author
@michaeljmarshall It's done, PTAL |
tisonkun
approved these changes
Aug 11, 2022
Member
|
@Shawyeok Thanks for your contribution! |
Technoboy-
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Aug 16, 2022
apache#15767) ### Motivation There are so many dispatcher blocked/unblocked log(more than 30K within 15 min), I supposed change it to debug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are so many dispatcher blocked/unblocked log(more than 30K within 15 min), I supposed change it to debug.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below or label this PR directly.
Need to update docs?
no-need-docJust change log level