[fix][tls] remove throw exception in getProvider

[nodece]

Signed-off-by: Zixuan Liu nodeces@gmail.com

Motivation

When cannot find the BouncyCastleFipsProvider or BouncyCastleProvider, we shouldn't throw any exception, it is unnecessary.

Modifications

• Remove throw exception in getProvider

Documentation

Need to update docs?

• no-need-doc

[poorbarcode]

I think: this patch is to solve the boot failure.

If return null, this public constant also will be null, I see this static constant is not used, can we deleted it ?

pulsar/pulsar-common/src/main/java/org/apache/pulsar/common/util/SecurityUtility.java

Line 74 in 46c2817

public static final Provider BC_PROVIDER = getProvider();

pulsar/pulsar-common/src/main/java/org/apache/pulsar/common/util/SecurityUtility.java

Lines 85 to 87 in 46c2817

	public static boolean isBCFIPS() {
	return BC_PROVIDER.getClass().getCanonicalName().equals(BC_FIPS_PROVIDER_CLASS);
	}

If we deleted the static constant, so we don't have to change this part:

pulsar/pulsar-common/src/main/java/org/apache/pulsar/common/util/SecurityUtility.java

Lines 109 to 114 in 46c2817

	try {
	return getBCProviderFromClassPath();
	} catch (Exception e) {
	log.warn("Not able to get Bouncy Castle provider for both FIPS and Non-FIPS from class path:", e);
	throw new RuntimeException(e);
	}

[Jason918]

LGTM

[nodece]

@poorbarcode We cannot delete these, it is used to load the Bouncy Castle provider.

[poorbarcode]

@poorbarcode We cannot delete these, it is used to load the Bouncy Castle provider.

Received, thank you.

[mattisonchao]

LGTM, left a trivial comment.

[mattisonchao]

Optional will be better than null.

[nodece]

We don't use this TLS provider, the purpose of this is to add a BC provider to the JDK.

[github-actions]

The pr had no activity for 30 days, mark with Stale label.