[fix][broker] Modify authorization to update topic's properties

[yuruguo]

Motivation

Current users with production permission can change the properties of topic in PR-#17238, which will cause the properties of topic to become uncontrollable due to arbitrary changes. In fact, only tenant administrator and super user can change them.

Modifications

• Modify TopicOperation.PRODUCE to TopicOperation.UPDATE_METADATA in internalUpdatePropertiesAsync method

Documentation

• doc-not-needed

Matching PR in forked repository

PR in forked repository:

[labuladong]

/pulsarbot rerun-failure-checks

[codelipenghui]

@yuruguo It's a behavior change. It's better to have a discussion under the dev mailing list to make sure everyone can know what will be changed.

[codecov-commenter]

Codecov Report

Merging #18252 (c6e9f99) into master (3f5acfe) will decrease coverage by 0.45%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master   #18252      +/-   ##
============================================
- Coverage     38.91%   38.46%   -0.46%     
+ Complexity     8283     8203      -80     
============================================
  Files           683      683              
  Lines         67290    67323      +33     
  Branches       7218     7215       -3     
============================================
- Hits          26187    25893     -294     
- Misses        38095    38485     +390     
+ Partials       3008     2945      -63     

Flag	Coverage Δ
unittests	38.46% <100.00%> (-0.46%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...pulsar/broker/admin/impl/PersistentTopicsBase.java	52.30% <100.00%> (-0.28%)	⬇️
.../pulsar/broker/service/SharedConsumerAssignor.java	3.70% <0.00%> (-57.41%)	⬇️
...lsar/broker/service/StickyKeyConsumerSelector.java	50.00% <0.00%> (-50.00%)	⬇️
...apache/pulsar/broker/service/TopicListService.java	10.65% <0.00%> (-44.27%)	⬇️
...apache/pulsar/broker/service/EntryAndMetadata.java	0.00% <0.00%> (-40.75%)	⬇️
...e/HashRangeExclusiveStickyKeyConsumerSelector.java	0.00% <0.00%> (-36.93%)	⬇️
...lsar/broker/loadbalance/impl/ThresholdShedder.java	3.26% <0.00%> (-30.07%)	⬇️
...tent/NonPersistentDispatcherMultipleConsumers.java	40.74% <0.00%> (-12.35%)	⬇️
...n/java/org/apache/pulsar/broker/service/Topic.java	9.09% <0.00%> (-9.10%)	⬇️
...org/apache/pulsar/broker/loadbalance/LoadData.java	58.33% <0.00%> (-8.34%)	⬇️
... and 32 more

[nodece]

@yuruguo It's a behavior change. It's better to have a discussion under the dev mailing list to make sure everyone can know what will be changed.

First, add this feature in #17238, which will release in the 2.12 version, no breaking changes.

[Technoboy-]

LGTM

[yuruguo]

@yuruguo It's a behavior change. It's better to have a discussion under the dev mailing list to make sure everyone can know what will be changed.

First, add this feature in #17238, which will release in the 2.12 version, no breaking changes.

You are right @nodece, PTAL @codelipenghui