-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve][ci] Add pulsar-client test group #18298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@lhotari Could you please take a look at this PR? |
Codecov Report
@@ Coverage Diff @@
## master #18298 +/- ##
============================================
- Coverage 38.97% 34.51% -4.46%
+ Complexity 8311 6493 -1818
============================================
Files 683 608 -75
Lines 67325 58071 -9254
Branches 7217 6054 -1163
============================================
- Hits 26239 20043 -6196
+ Misses 38079 35387 -2692
+ Partials 3007 2641 -366
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/pulsarbot rerun-failure-checks |
- This change was missing from apache#18298
@mattisonchao I didn't have time to review before this was merged. /cc @codelipenghui
@yaalsn The pulsar-client module tests were run as part of the OTHER test group and continue to run as part of that group. I created PR #18339 to address that. |
|
I hope Pulsar CI changes like this could be reviewed carefully before merging so that we don't needlessly make changes. If gaps are detected, it's worth bringing up to discussion on dev mailing list or on Pulsar slack on the #testing channel. |
- This change was missing from #18298
Motivation
pulsar-clienttest group is not in CI, but this module is important and we need to make sure of its quality.Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: https://github.com/yaalsn/pulsar/pull/15