Skip to content

Conversation

@yaalsn
Copy link
Contributor

@yaalsn yaalsn commented Nov 2, 2022

Motivation

pulsar-client test group is not in CI, but this module is important and we need to make sure of its quality.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: https://github.com/yaalsn/pulsar/pull/15

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 2, 2022
@codelipenghui codelipenghui added this to the 2.12.0 milestone Nov 3, 2022
@mattisonchao mattisonchao requested a review from lhotari November 3, 2022 09:04
@mattisonchao mattisonchao reopened this Nov 3, 2022
@mattisonchao
Copy link
Member

@lhotari Could you please take a look at this PR?

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Merging #18298 (ed66cc8) into master (0866c3a) will decrease coverage by 4.45%.
The diff coverage is 48.43%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18298      +/-   ##
============================================
- Coverage     38.97%   34.51%   -4.46%     
+ Complexity     8311     6493    -1818     
============================================
  Files           683      608      -75     
  Lines         67325    58071    -9254     
  Branches       7217     6054    -1163     
============================================
- Hits          26239    20043    -6196     
+ Misses        38079    35387    -2692     
+ Partials       3007     2641     -366     
Flag Coverage Δ
unittests 34.51% <48.43%> (-4.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../main/java/org/apache/pulsar/PulsarStandalone.java 0.00% <ø> (ø)
...che/pulsar/broker/BookKeeperClientFactoryImpl.java 0.00% <0.00%> (ø)
.../org/apache/pulsar/broker/admin/AdminResource.java 32.02% <0.00%> (-34.49%) ⬇️
...pulsar/broker/admin/impl/PersistentTopicsBase.java 11.96% <0.00%> (-40.34%) ⬇️
...pache/pulsar/broker/admin/v2/PersistentTopics.java 6.63% <0.00%> (-64.17%) ⬇️
...pulsar/broker/service/PulsarCommandSenderImpl.java 70.68% <ø> (-3.68%) ⬇️
...ersistentStreamingDispatcherMultipleConsumers.java 0.00% <0.00%> (ø)
...sar/broker/service/persistent/PersistentTopic.java 44.51% <0.00%> (-12.47%) ⬇️
...ransaction/buffer/impl/InMemTransactionBuffer.java 0.00% <ø> (ø)
...nsaction/buffer/impl/TransactionBufferDisable.java 52.63% <ø> (ø)
... and 394 more

@yaalsn
Copy link
Contributor Author

yaalsn commented Nov 3, 2022

/pulsarbot rerun-failure-checks

@codelipenghui codelipenghui merged commit baab40b into apache:master Nov 3, 2022
lhotari added a commit to lhotari/pulsar that referenced this pull request Nov 4, 2022
@lhotari
Copy link
Member

lhotari commented Nov 4, 2022

@lhotari Could you please take a look at this PR?

@mattisonchao I didn't have time to review before this was merged. /cc @codelipenghui

pulsar-client test group is not in CI, but this module is important and we need to make sure of its quality.

@yaalsn The pulsar-client module tests were run as part of the OTHER test group and continue to run as part of that group. I created PR #18339 to address that.

@lhotari
Copy link
Member

lhotari commented Nov 4, 2022

I hope Pulsar CI changes like this could be reviewed carefully before merging so that we don't needlessly make changes. If gaps are detected, it's worth bringing up to discussion on dev mailing list or on Pulsar slack on the #testing channel.

lhotari added a commit that referenced this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants