Skip to content

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Nov 4, 2022

Motivation

Modifications

  • Add skipTestsForUnitGroupOther maven profile to pulsar-client/pom.xml so that the tests don't get run as part of OTHER group.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: lhotari#102

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Merging #18339 (0c22844) into master (67d9d63) will increase coverage by 5.61%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18339      +/-   ##
============================================
+ Coverage     40.29%   45.90%   +5.61%     
- Complexity     8685    10057    +1372     
============================================
  Files           687      687              
  Lines         67441    67444       +3     
  Branches       7225     7226       +1     
============================================
+ Hits          27175    30961    +3786     
+ Misses        37257    32913    -4344     
- Partials       3009     3570     +561     
Flag Coverage Δ
unittests 45.90% <0.00%> (+5.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...che/bookkeeper/mledger/impl/ManagedCursorImpl.java 36.81% <0.00%> (-0.09%) ⬇️
...rg/apache/bookkeeper/mledger/impl/OpReadEntry.java 65.55% <ø> (+0.72%) ⬆️
...g/apache/pulsar/client/impl/RawBatchConverter.java 3.12% <0.00%> (-89.07%) ⬇️
.../pulsar/broker/service/SharedConsumerAssignor.java 3.70% <0.00%> (-74.08%) ⬇️
.../transaction/buffer/metadata/AbortTxnMetadata.java 28.57% <0.00%> (-57.15%) ⬇️
...lsar/broker/service/StickyKeyConsumerSelector.java 50.00% <0.00%> (-50.00%) ⬇️
...apache/pulsar/broker/service/TopicListService.java 10.65% <0.00%> (-44.27%) ⬇️
...ion/buffer/metadata/TransactionBufferSnapshot.java 42.85% <0.00%> (-42.86%) ⬇️
...apache/pulsar/broker/service/EntryAndMetadata.java 0.00% <0.00%> (-40.75%) ⬇️
...e/HashRangeExclusiveStickyKeyConsumerSelector.java 0.00% <0.00%> (-36.93%) ⬇️
... and 225 more

@lhotari lhotari merged commit 73af30c into apache:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants